Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release #528

Closed
roadscape opened this issue Jan 14, 2019 · 4 comments
Closed

New release #528

roadscape opened this issue Jan 14, 2019 · 4 comments
Labels

Comments

@roadscape
Copy link

Issue #364 was resolved with PR #452 back in October, but there hasn't been a 0.16.0 release. (0.15.0 was released Aug 14, 2018)

I attempted to work around this using dependency_links, but this doesn't work since 0.15.0 is what's hardcoded on master and this bug prevents using a newer commit hash.

Could we have a new release soon? :)

@aio-libs-bot
Copy link

GitMate.io thinks possibly related issues are #225 (when a new release?), #411 (Broken compatibility with new release of SQLAlchemy 1.2.0), and #495 (handle Invalid transaction status on released connection).

@roadscape
Copy link
Author

roadscape commented Jan 14, 2019

After testing master I saw lots of InterfaceError: cursor already closed errors.


Update: it was my misuse of aiopg.sa. The code (which works in 0.15.0) boiled down to:

        async with db.acquire() as conn:
            cursor = await conn.execute(sql, **kwargs)
        res = await cursor.fetchall()

On master this causes cursor already closed errors, with the solution being to put usage of the cursor into the conn context.

@vir-mir
Copy link
Member

vir-mir commented Jan 25, 2019

Yes, this is due to the fact that in psycopg2 the cursor is not asynchronous.

@vir-mir
Copy link
Member

vir-mir commented Jan 26, 2019

@vir-mir vir-mir removed the bug label Jan 26, 2019
@vir-mir vir-mir closed this as completed Jan 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants