Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve issue 364 #452

Merged
merged 10 commits into from
Oct 16, 2018
Merged

resolve issue 364 #452

merged 10 commits into from
Oct 16, 2018

Conversation

thehesiod
Copy link
Contributor

@thehesiod thehesiod commented Mar 18, 2018 •
edited
Loading

resolves #364

@thehesiod
Copy link
Contributor Author

will need to re-work this to enforce one cursor per connection, is slightly more complicated

@codecov
Copy link

codecov bot commented Mar 22, 2018 •
edited
Loading

Codecov Report

Merging #452 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #452      +/-   ##
==========================================
- Coverage   93.67%   93.66%   -0.01%     
==========================================
  Files          25       25              
  Lines        3733     3744      +11     
  Branches      198      199       +1     
==========================================
+ Hits         3497     3507      +10     
- Misses        198      199       +1     
  Partials       38       38
Impacted Files Coverage Δ
tests/test_pool.py 99.75% <ø> (ø) ⬆️
tests/pep492/test_async_await.py 100% <100%> (ø) ⬆️
aiopg/pool.py 98.92% <100%> (ø) ⬆️
tests/test_connection.py 98.23% <100%> (ø) ⬆️
aiopg/cursor.py 98.78% <100%> (+0.02%) ⬆️
aiopg/utils.py 83.43% <0%> (-0.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d9493a...59942d5. Read the comment docs.

@thehesiod
Copy link
Contributor Author

ok, it now enforces one cursor per connection

@vir-mir
Copy link
Member

vir-mir commented Apr 3, 2018

@thehesiod you add tests?

@vir-mir vir-mir closed this Apr 3, 2018
@vir-mir vir-mir reopened this Apr 3, 2018
@thehesiod
Copy link
Contributor Author

ok added a specific test

@thehesiod
Copy link
Contributor Author

@asvetlov anything left for this?

@thehesiod
Copy link
Contributor Author

bumped to 0.14

@thehesiod
Merge remote-tracking branch 'aio-libs/master' into thehesiod/conn_cu…
2730c15 
…rsor_tracking

# Conflicts:
#	.gitignore
#	aiopg/__init__.py
#	setup.py
@thehesiod
Copy link
Contributor Author

@vir-mir anything left to merge this?

vir-mir
vir-mir reviewed Oct 15, 2018
View reviewed changes
aiopg/__init__.py Outdated
@@ -11,7 +11,7 @@
'version', 'version_info', 'DEFAULT_TIMEOUT', 'IsolationLevel',
'Transaction')

__version__ = '0.15.0'
__version__ = '0.16.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to lift the version in a separate pull request

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean: "no need to life the version, it will be done in a separate pull request"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is usually done release engineer, there may already be several tasks in the issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, reverted

@vir-mir
Copy link
Member

vir-mir commented Oct 16, 2018

ok, merge into master

@vir-mir vir-mir merged commit 8cea23e into aio-libs:master Oct 16, 2018
@thehesiod thehesiod deleted the thehesiod/conn_cursor_tracking branch October 16, 2018 21:08
@smagafurov
Copy link
Contributor

Can you bump version with this fix?

@roadscape roadscape mentioned this pull request Jan 14, 2019
Closed
@vir-mir vir-mir mentioned this pull request Feb 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vir-mir vir-mir vir-mir left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

close cannot be used while an asynchronous query is underway
3 participants
@thehesiod @vir-mir @smagafurov