Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional benchmarks for common cases #1254

Merged
merged 1 commit into from
Oct 13, 2024
Merged

Add additional benchmarks for common cases #1254

merged 1 commit into from
Oct 13, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 13, 2024

  • Checking equality
  • Checking for is_default_port

- Checking equality
- Checking for is_default_port
@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Oct 13, 2024
tests/test_url_benchmarks.py Dismissed Show dismissed Hide dismissed
tests/test_url_benchmarks.py Dismissed Show dismissed Hide dismissed
tests/test_url_benchmarks.py Dismissed Show dismissed Hide dismissed
tests/test_url_benchmarks.py Dismissed Show dismissed Hide dismissed
tests/test_url_benchmarks.py Dismissed Show dismissed Hide dismissed
Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.83%. Comparing base (e1a4d51) to head (ecea661).
Report is 189 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1254      +/-   ##
==========================================
+ Coverage   95.82%   95.83%   +0.01%     
==========================================
  Files          27       27              
  Lines        5153     5167      +14     
  Branches      312      314       +2     
==========================================
+ Hits         4938     4952      +14     
  Misses        189      189              
  Partials       26       26              
Flag Coverage Δ
CI-GHA 95.81% <100.00%> (+0.01%) ⬆️
MyPy 43.80% <71.42%> (+0.07%) ⬆️
OS-Linux 99.35% <100.00%> (+<0.01%) ⬆️
OS-Windows 99.41% <100.00%> (+<0.01%) ⬆️
OS-macOS 99.06% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 98.97% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 99.23% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 99.23% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 98.97% <100.00%> (+<0.01%) ⬆️
Py-3.12.7 99.23% <100.00%> (+<0.01%) ⬆️
Py-3.13.0 99.23% <100.00%> (+<0.01%) ⬆️
Py-3.8.10 98.92% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 99.18% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 98.92% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 99.18% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.11 99.24% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 99.24% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.17 99.26% <100.00%> (+<0.01%) ⬆️
VM-macos-latest 99.06% <100.00%> (+<0.01%) ⬆️
VM-ubuntu-latest 99.35% <100.00%> (+<0.01%) ⬆️
VM-windows-latest 99.41% <100.00%> (+<0.01%) ⬆️
pytest 99.35% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Oct 13, 2024

CodSpeed Performance Report

Merging #1254 will not alter performance

Comparing benchmarks (ecea661) with master (e1a4d51)

Summary

✅ 43 untouched benchmarks

🆕 2 new benchmarks

Benchmarks breakdown

Benchmark master benchmarks Change
🆕 test_is_default_port N/A 198 µs N/A
🆕 test_url_equality N/A 1.9 ms N/A

@bdraco bdraco marked this pull request as ready for review October 13, 2024 15:46
@bdraco bdraco enabled auto-merge (squash) October 13, 2024 15:46
@bdraco bdraco merged commit 91c4d92 into master Oct 13, 2024
47 of 49 checks passed
@bdraco bdraco deleted the benchmarks branch October 13, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant