Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update vm-api lib to rev-df350b1 #386

Merged
merged 1 commit into from
Apr 2, 2019
Merged

update vm-api lib to rev-df350b1 #386

merged 1 commit into from
Apr 2, 2019

Conversation

AionJayT
Copy link
Collaborator

@AionJayT AionJayT commented Apr 2, 2019

aionnetwork/vm_api@df350b1

Currently, the mpm is using this rev due to the PR merge aionnetwork/aion#851

@AionJayT AionJayT requested a review from jeff-aion April 2, 2019 18:28
@jeff-aion
Copy link
Contributor

Is this just to depend on the same version for this release or do we need changes to AVM which depend on changes in this version?

If it is just to keep these in sync for the release, were we waiting for any other changes, first?

@AionJayT
Copy link
Collaborator Author

AionJayT commented Apr 2, 2019

It is just keeping sync with the kernel, vm-api and avm change.
When I checked the mpm repo ref, found this issue, the kernel already use the new vm-api revision, but the avm still ref to the old vm-api revision.

@AionJayT
Copy link
Collaborator Author

AionJayT commented Apr 2, 2019

And it should use for the kernel 0.3.4 release.

@AionJayT AionJayT changed the title update vm-api lib to rev-e8657a6 update vm-api lib to rev-df350b1 Apr 2, 2019
@AionJayT AionJayT merged commit f481600 into master Apr 2, 2019
@AionJayT AionJayT deleted the update-vm-api branch April 2, 2019 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants