Unity interleave/asr #1015
Merged
Unity interleave/asr #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This test can unpredictably fail without this, depending on the order in which tests before it were run.
- A future block is any block with a timestamp greater than system time + 1 second - This is important for Unity to work correctly
…dFetchSUmmary() - This check now happens in FutureBlockRule
- Rather than retrieving the coinbase from the Staker Registry, we expect users to provide it - This commit also includes some cleanup of the RPC-related functionality
- This commit adds a new method to A0BlockHeader that updates the timestamp of the header
- The chains produced in this test will become invalid when Unity Interleave is implemented
…he chain - This rule is only enforced after the Unity fork point
arajasek
force-pushed
the
unity-interleave/asr
branch
2 times, most recently
from
c210cd6 to
eb1fdab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice
Please submit your PR to the
masterbranch and rebase your code onmasterbefore opening the pull request.Description
Please include a brief summary of the change that this pull request proposes. Include any relevant motivation and context. List any dependencies required for this change.
Fixes Issue # .
Type of change
Insert x into the following checkboxes to confirm (eg. [x]):
Testing
Please describe the tests you used to validate this pull request. Provide any relevant details for test configurations as well as any instructions to reproduce these results.