AKI-435: Refactoring ContractDetails (Part 1) #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandraRoatis
force-pushed
the
AKI-435
branch
2 times, most recently
from
79b46dc to
70c8e20
Compare
- the method was used only for testing, so it was moved to the test class.
- removed inheritance from AbstractContractDetails and instance variables that were not used by the implementation.
- removed inheritance from AbstractContractDetails; - deleted abstract class.
- correctly retrieving the code based on its hash in tests; - updated toString methods to print all stored codes.
AlexandraRoatis
force-pushed
the
AKI-435
branch
from
70c8e20 to
3b5bf3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ContractDetailsinterface to avoid cast toAbstractContractDetails;setStoragemethod fromContractDetailsinterface. The method was used only for testing, so it was moved to the test class.AbstractContractDetailsintoContractDetailsCacheImpl. Removed inheritance fromAbstractContractDetailsand instance variables that were not used by the implementation.AbstractContractDetailsintoAionContractDetailsImpl. Removed inheritance fromAbstractContractDetailsand deleted the abstract class.ContractDetailsinterface (implementation detail).Type of change
Insert x into the following checkboxes to confirm (eg. [x]):