Refactor contract details for FVM #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AionGenesis used a specialised case of instatiating FvmContractDetails for the network balance pre-compiled contract. This specialisation is not necessary since the same result can be achieved through the direct used of the SecureTrie.
AlexandraRoatis
added
enhancement
Tests 1 and 2 still provided some utility so they were refactored to increase readability. The external storage serialization test was no longer useful.
AlexandraRoatis
force-pushed
the
AKI-435-PR
branch
from
b347df4 to
79ab01c
Compare
AlexandraRoatis
removed
the
wip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change