Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import blocks in batches #1118

Merged
merged 6 commits into from
Feb 25, 2020
Merged

Import blocks in batches #1118

merged 6 commits into from
Feb 25, 2020

Conversation

AlexandraRoatis
Copy link
Contributor

Type of change

  • Bug fix.
  • New feature.
  • Enhancement.
  • Unit test.
  • Breaking change (a fix or feature that causes existing functionality to not work as expected).
  • Requires documentation update.

@AlexandraRoatis AlexandraRoatis added the enhancement New feature or request label Feb 20, 2020
@AlexandraRoatis AlexandraRoatis added this to the 1.4 milestone Feb 20, 2020
@AlexandraRoatis AlexandraRoatis self-assigned this Feb 20, 2020
@AlexandraRoatis
Remove method for compacting the state
c301a65 
Past attempts to use this during sync led to bad performance.
@AlexandraRoatis
AKI-440: Remove time parameter from tryToConnect
bdda689 
The timestamp check was already moved to FutureBlockRule making the current
time parameter unnecessary. The internal method was only updating the time
parameter, hence it was removed as well.
@AlexandraRoatis
Survey import time inside the blockchain class
7075ada 
Additionally:
- updated the blockchain close method which was oddly closing
only the blockstore, and
- removed the use of the close method in tests, since the
StandaloneBlockchain uses MockDB which does not need closing.
@AlexandraRoatis AlexandraRoatis force-pushed the AKI-308 branch 2 times, most recently from aec6547 to 94a7cb1 Compare February 25, 2020 19:16
@AlexandraRoatis AlexandraRoatis force-pushed the AKI-308 branch 2 times, most recently from 56cbc21 to 16c5c7d Compare February 25, 2020 19:46
@AlexandraRoatis AlexandraRoatis merged commit 16c5c7d into master Feb 25, 2020
@AlexandraRoatis AlexandraRoatis deleted the AKI-308 branch February 25, 2020 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AionJayT AionJayT Awaiting requested review from AionJayT

Assignees

@AlexandraRoatis AlexandraRoatis

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
1 participant
@AlexandraRoatis