Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preemptive measures for exceptions and correct for repository snapshots #688

Merged
merged 2 commits into from
Oct 31, 2018

Conversation

AlexandraRoatis
Copy link
Contributor

Description

  1. Added catch statements and default return values for non-critical functionality relating to the PendingBlockStore.
  2. Copying the reference to the pendingBlockStore when creating snapshots to avoid null pointer exceptions if the store is accessed from the snapshot.

Type of change

Insert x into the following checkboxes to confirm (eg. [x]):

  • Bug fix.
  • New feature.
  • Enhancement.
  • Unit test.
  • Breaking change (a fix or feature that causes existing functionality to not work as expected).
  • Requires documentation update.

Testing

Please describe the tests you used to validate this pull request. Provide any relevant details for test configurations as well as any instructions to reproduce these results.

  • existing test suite

Verification

Insert x into the following checkboxes to confirm (eg. [x]):

  • I have self-reviewed my own code and conformed to the style guidelines of this project.
  • New and existing tests pass locally with my changes.
  • I have added tests for my fix or feature.
  • I have made appropriate changes to the corresponding documentation.
  • My code generates no new warnings.
  • Any dependent changes have been made.

@AlexandraRoatis AlexandraRoatis added bug Something isn't working enhancement New feature or request labels Oct 31, 2018
@AlexandraRoatis AlexandraRoatis added this to the 0.3.2 milestone Oct 31, 2018
Copy link
Collaborator

@AionJayT AionJayT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix

Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@AionJayT AionJayT merged commit 696024c into master-pre-merge Oct 31, 2018
@AlexandraRoatis AlexandraRoatis deleted the repo-fix branch October 31, 2018 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants