Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difficulty length check #711

Merged
merged 8 commits into from
Nov 20, 2018
Merged

Difficulty length check #711

merged 8 commits into from
Nov 20, 2018

Conversation

AionJayT
Copy link
Collaborator

Notice

It is not allowed to submit your PR to the master branch directly, please submit your PR to the master-pre-merge branch.

Description

Please include a brief summary of the change that this pull request proposes. Include any relevant motivation and context. List any dependencies required for this change.

  • The PR is mainly for adding difficulty length check in the header rule to prevent adversary padding big
    date into this field.

Fixes Issue # .

Type of change

Insert x into the following checkboxes to confirm (eg. [x]):

  • Bug fix.
  • New feature.
  • Enhancement.
  • Unit test.
  • Breaking change (a fix or feature that causes existing functionality to not work as expected).
  • Requires documentation update.

Testing

Please describe the tests you used to validate this pull request. Provide any relevant details for test configurations as well as any instructions to reproduce these results.

Verification

Insert x into the following checkboxes to confirm (eg. [x]):

  • I have self-reviewed my own code and conformed to the style guidelines of this project.
  • New and existing tests pass locally with my changes.
  • I have added tests for my fix or feature.
  • I have made appropriate changes to the corresponding documentation.
  • My code generates no new warnings.
  • Any dependent changes have been made.

@AionJayT AionJayT added the bug Something isn't working label Nov 19, 2018
@AionJayT AionJayT added this to the 0.3.2 milestone Nov 19, 2018
@AionJayT AionJayT self-assigned this Nov 19, 2018
@AionJayT AionJayT requested a review from iamyulong November 19, 2018 21:45
Copy link
Contributor

@AlexandraRoatis AlexandraRoatis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with some minor comments

modMcf/src/org/aion/mcf/types/AbstractBlockHeader.java Outdated Show resolved Hide resolved
modMcf/src/org/aion/mcf/types/AbstractBlockHeader.java Outdated Show resolved Hide resolved
modMcf/test/org/aion/valid/DifficultyRuleTest.java Outdated Show resolved Hide resolved
modMcf/test/org/aion/valid/DifficultyRuleTest.java Outdated Show resolved Hide resolved
Copy link
Contributor

@aion-kelvin aion-kelvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just have one JavaDoc-related request.

@AionJayT AionJayT merged commit 6a9c49e into master-pre-merge Nov 20, 2018
@AionJayT AionJayT deleted the difficultyCheck branch December 11, 2018 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants