Support "pending" option for Web3 requests #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aion-kelvin
suggested changes
Nov 20, 2018
| @@ -2872,6 +2838,14 @@ private IRepository getRepoByJsonBlockId(String _bnOrId) { | |||
| return ac.getRepository().getSnapshotTo(b.getStateRoot()); | |||
| } | |||
|
|
|||
| private AionBlock getBlockByBN(Long bn) { | |||
There was a problem hiding this comment.
I think long is better than Long here (probably doesn't make sense to pass in null)
| @@ -2872,6 +2838,14 @@ private IRepository getRepoByJsonBlockId(String _bnOrId) { | |||
| return ac.getRepository().getSnapshotTo(b.getStateRoot()); | |||
| } | |||
|
|
|||
| private AionBlock getBlockByBN(Long bn) { | |||
| if (bn < 0) { | |||
There was a problem hiding this comment.
Should this not be bn == -1 instead?
(And if so, I think it'd be good to put -1 in a const like 'BEST_PENDING_BLOCK' or something to that effect)
| return null; | ||
| } | ||
|
|
||
| if (bn < 0) return pendingState.getRepository(); |
There was a problem hiding this comment.
Should it not be bn == -1?
arajasek
force-pushed
the
pending-api
branch
from
ade1447 to
651fab7
Compare
|
All suggested changes have been implemented :) |
aion-kelvin
approved these changes
Nov 20, 2018
| @@ -1100,6 +1102,11 @@ private FltrLg createFilter(ArgFltr rf) { | |||
| return null; | |||
| } | |||
|
|
|||
| if (bnTo != BEST_PENDING_BLOCK && (bnFrom > bnTo)) { | |||
There was a problem hiding this comment.
nit: unnecessary parens
arajasek
force-pushed
the
pending-api
branch
from
651fab7 to
6f90eed
Compare
AionJayT
approved these changes
Nov 20, 2018
AlexandraRoatis
approved these changes
Nov 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice
It is not allowed to submit your PR to the master branch directly, please submit your PR to the master-pre-merge branch.
Description
Adds the "pending" option for the missing functions, thus fixing issue #709.
Type of change
Insert x into the following checkboxes to confirm (eg. [x]):
Testing
All existing tests pass, new tests added.
Verification
Insert x into the following checkboxes to confirm (eg. [x]):