Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up some trie functionality #813

Merged
merged 2 commits into from
Feb 7, 2019
Merged

Conversation

AlexandraRoatis
Copy link
Contributor

Description

  1. Commented out some unused functionality.
  2. Cleaned up the object construction process by adding a constructor using a cache.

Type of change

Insert x into the following checkboxes to confirm (eg. [x]):

  • Bug fix.
  • New feature.
  • Enhancement.
  • Unit test.
  • Breaking change (a fix or feature that causes existing functionality to not work as expected).
  • Requires documentation update.

Testing

Please describe the tests you used to validate this pull request. Provide any relevant details for test configurations as well as any instructions to reproduce these results.

  • existing test suite + --redo-import on mastery

Verification

Insert x into the following checkboxes to confirm (eg. [x]):

  • I have self-reviewed my own code and conformed to the style guidelines of this project.
  • New and existing tests pass locally with my changes.
  • I have added tests for my fix or feature.
  • I have made appropriate changes to the corresponding documentation.
  • My code generates no new warnings.
  • Any dependent changes have been made.

@AlexandraRoatis AlexandraRoatis changed the base branch from master to master-pre-merge February 7, 2019 15:54
@AlexandraRoatis AlexandraRoatis added the enhancement New feature or request label Feb 7, 2019
@AlexandraRoatis AlexandraRoatis added this to the 0.3.3 milestone Feb 7, 2019
@AlexandraRoatis AlexandraRoatis self-assigned this Feb 7, 2019
@AionJayT AionJayT merged commit f450c70 into master-pre-merge Feb 7, 2019
@AlexandraRoatis AlexandraRoatis deleted the trie-clean branch February 7, 2019 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants