Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove aion_api submodule #821

Merged
merged 3 commits into from
Feb 14, 2019
Merged

Remove aion_api submodule #821

merged 3 commits into from
Feb 14, 2019

Conversation

aion-kelvin
Copy link
Contributor

@aion-kelvin aion-kelvin commented Feb 12, 2019

Notice

It is not allowed to submit your PR to the master branch directly, please submit your PR to the master-pre-merge branch.

Description

Please include a brief summary of the change that this pull request proposes. Include any relevant motivation and context. List any dependencies required for this change.

Fixes Issue # .

Type of change

Insert x into the following checkboxes to confirm (eg. [x]):

  • Bug fix.
  • New feature.
  • Enhancement.
  • Unit test.
  • Breaking change (a fix or feature that causes existing functionality to not work as expected).
  • Requires documentation update.

Testing

Please describe the tests you used to validate this pull request. Provide any relevant details for test configurations as well as any instructions to reproduce these results.

  • compiled and did pack build, then made sure the new pack output's kernel can start up

Verification

Insert x into the following checkboxes to confirm (eg. [x]):

  • I have self-reviewed my own code and conformed to the style guidelines of this project.
  • New and existing tests pass locally with my changes.
  • I have added tests for my fix or feature.
  • I have made appropriate changes to the corresponding documentation.
  • My code generates no new warnings.
  • Any dependent changes have been made.

@aion-kelvin aion-kelvin self-assigned this Feb 12, 2019
@aion-kelvin aion-kelvin added this to the 0.3.3 milestone Feb 12, 2019
Copy link
Collaborator

@AionJayT AionJayT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexandraRoatis AlexandraRoatis added the build script Build script change only label Feb 13, 2019
@AionJayT AionJayT merged commit 67b564d into master-pre-merge Feb 14, 2019
@aion-kelvin aion-kelvin deleted the no-aion-api branch February 20, 2019 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build script Build script change only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants