Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add handling for the vm fatal status #843

Merged
merged 12 commits into from
Mar 14, 2019
Merged

Conversation

AionJayT
Copy link
Collaborator

@AionJayT AionJayT commented Mar 8, 2019

Notice

It is not allowed to submit your PR to the master branch directly, please submit your PR to the master-pre-merge branch.

Description

Please include a brief summary of the change that this pull request proposes. Include any relevant motivation and context. List any dependencies required for this change.

Current kernel doesn't cache the VM happens the fatal case (e.g. VM OOM). It should be shut down immediately when the fatal issue happens.

Fixes Issue # .

Type of change

Insert x into the following checkboxes to confirm (eg. [x]):

  • Bug fix.
  • New feature.
  • Enhancement.
  • Unit test.
  • Breaking change (a fix or feature that causes existing functionality to not work as expected).
  • Requires documentation update.

Testing

Please describe the tests you used to validate this pull request. Provide any relevant details for test configurations as well as any instructions to reproduce these results.

  • Add a mock test case.

Verification

Insert x into the following checkboxes to confirm (eg. [x]):

  • I have self-reviewed my own code and conformed to the style guidelines of this project.
  • New and existing tests pass locally with my changes.
  • I have added tests for my fix or feature.
  • I have made appropriate changes to the corresponding documentation.
  • My code generates no new warnings.
  • Any dependent changes have been made.

@AionJayT AionJayT added the bug Something isn't working label Mar 8, 2019
@AionJayT AionJayT added this to the 0.4.0 milestone Mar 8, 2019
@AionJayT AionJayT changed the base branch from rearchitect-repo to master-pre-merge March 13, 2019 19:46
@AionJayT AionJayT merged commit 284c1cf into master-pre-merge Mar 14, 2019
@AionJayT AionJayT deleted the vm-fatal-case branch March 15, 2019 19:14
@AionJayT AionJayT modified the milestones: 0.4.0, 0.3.4 Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants