Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync stats expansion & refactor #844

Merged
merged 15 commits into from
Mar 20, 2019
Merged

Conversation

beidouz
Copy link
Contributor

@beidouz beidouz commented Mar 11, 2019

Notice

It is not allowed to submit your PR to the master branch directly, please submit your PR to the master-pre-merge branch.

Description

Please include a brief summary of the change that this pull request proposes. Include any relevant motivation and context. List any dependencies required for this change.

  • Created statsTrackers to store different types of sync stats functionalities
  • Added BLOCKS, RECEIPTS and TRIE_DATA to the enum RequestType
  • Refactored ResponseStatsTracker to avoid code repetition
  • Expanded Request & Response tracking to include the new request types.
  • Removed use of StandaloneBlockchain from SyncStatsTest

Todo: Log statistics regarding the new types of messages from the corresponding handlers/tasks (After fast sync is merged)

Fixes Issue #837

Type of change

Insert x into the following checkboxes to confirm (eg. [x]):

  • Bug fix.
  • New feature.
  • Enhancement.
  • Unit test.
  • Breaking change (a fix or feature that causes existing functionality to not work as expected).
  • Requires documentation update.

Testing

Please describe the tests you used to validate this pull request. Provide any relevant details for test configurations as well as any instructions to reproduce these results.

  • Fixed and added tests in SyncStatsTest

Verification

Insert x into the following checkboxes to confirm (eg. [x]):

  • I have self-reviewed my own code and conformed to the style guidelines of this project.
  • New and existing tests pass locally with my changes.
  • I have added tests for my fix or feature.
  • I have made appropriate changes to the corresponding documentation.
  • My code generates no new warnings.
  • Any dependent changes have been made.

@beidouz beidouz added the enhancement New feature or request label Mar 11, 2019
@beidouz beidouz added this to the 0.4.0 milestone Mar 11, 2019
@beidouz beidouz self-assigned this Mar 11, 2019
@beidouz beidouz requested a review from AlexandraRoatis March 11, 2019 18:21
@beidouz beidouz force-pushed the sync-stats-expansion branch from 5a67b17 to 7b56dc7 Compare March 11, 2019 18:27
Copy link
Contributor

@AlexandraRoatis AlexandraRoatis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functionality looks good, but I'd like some more code cleanup before we merge this (as described in the comments). Also, please ensure full test coverage of the tracker classes.

@beidouz beidouz force-pushed the sync-stats-expansion branch from 76f1008 to fbb53d2 Compare March 14, 2019 18:26
@beidouz beidouz force-pushed the sync-stats-expansion branch from cf540bc to 41d71d2 Compare March 19, 2019 20:28
Copy link
Collaborator

@AionJayT AionJayT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AionJayT AionJayT merged commit 453156b into master-pre-merge Mar 20, 2019
@AlexandraRoatis AlexandraRoatis deleted the sync-stats-expansion branch March 20, 2019 15:42
@AionJayT AionJayT modified the milestones: 0.4.0, 0.3.4 Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants