Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Refactoring in repo, trie and rlp #846

Merged
merged 4 commits into from
Mar 15, 2019

Conversation

AionJayT
Copy link
Collaborator

Notice

It is not allowed to submit your PR to the master branch directly, please submit your PR to the master-pre-merge branch.

Description

Please include a brief summary of the change that this pull request proposes. Include any relevant motivation and context. List any dependencies required for this change.

  • Small refactoring by going through the block import logic. Currently, the repo performance will be binding with the trieImpl and rlp. We can try to re-implement it in the future.

Fixes Issue # . N/A

Type of change

Insert x into the following checkboxes to confirm (eg. [x]):

  • Bug fix.
  • New feature.
  • Enhancement.
  • Unit test.
  • Breaking change (a fix or feature that causes existing functionality to not work as expected).
  • Requires documentation update.

Testing

Please describe the tests you used to validate this pull request. Provide any relevant details for test configurations as well as any instructions to reproduce these results.

  • N/A

Verification

Insert x into the following checkboxes to confirm (eg. [x]):

  • I have self-reviewed my own code and conformed to the style guidelines of this project.
  • New and existing tests pass locally with my changes.
  • I have added tests for my fix or feature.
  • I have made appropriate changes to the corresponding documentation.
  • My code generates no new warnings.
  • Any dependent changes have been made.

@AionJayT AionJayT added the enhancement New feature or request label Mar 13, 2019
@AionJayT AionJayT added this to the 0.4.0 milestone Mar 13, 2019
Copy link
Contributor

@AlexandraRoatis AlexandraRoatis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments

modRlp/src/main/java/org/aion/rlp/RLP.java Outdated Show resolved Hide resolved
modRlp/src/main/java/org/aion/rlp/RLP.java Outdated Show resolved Hide resolved
@AlexandraRoatis AlexandraRoatis merged commit a743a9a into master-pre-merge Mar 15, 2019
@AlexandraRoatis AlexandraRoatis deleted the rearchitect-repoenhance branch March 15, 2019 18:40
@AionJayT AionJayT modified the milestones: 0.4.0, 0.3.4 Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants