Avm now handles "pure" balance transfers #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aionick
requested review from
arajasek,
AlexandraRoatis,
AionJayT and
aion-kelvin
AionJayT
force-pushed
the
master-pre-merge
branch
from
93840d6 to
284c1cf
Compare
aion-kelvin
approved these changes
Mar 15, 2019
|
I won't have time to do the assertThat change, I'll try to keep it in mind in the future |
AionJayT
reviewed
Mar 15, 2019
| nextBatchToExecute = | ||
| fetchNextBatchOfTransactionsForAionVirtualMachine(currentIndex); | ||
| fetchNextBatchOfTransactionsForFastVirtualMachine(currentIndex); |
There was a problem hiding this comment.
reason for reversing avm fvm order in the if-else condition?
There was a problem hiding this comment.
Just seems more natural to do if (condition) instead of if (!condition)
AlexandraRoatis
approved these changes
Mar 15, 2019
|
please fix the conflict. Thanks |
AionJayT
requested changes
Mar 15, 2019
arajasek
approved these changes
Mar 15, 2019
- These consensus tests anticipate the next commit, which seeks to move "pure balance transfers" to the Avm instead of the Fvm. - These are also just going to be valuable to have going forward.
- A pure balance transfer is just a balance transfer to a non-contract address. Formerly these were handled by the Fvm, now they are handled by the Avm.
aionick
force-pushed
the
nick-balance-transfer
branch
from
b177d64 to
c843595
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BulkExecutor; namely, removing the unnecessaryisTransactionForFvm()method which must simply return!isTransactionForAvm().BulkExecutor, which only does these actions if the transaction is not avm-bound.The actual changes to logic are in commit b177d64 (the other commit, b61bc8c contains tests).
Type of change
Insert x into the following checkboxes to confirm (eg. [x]):
Testing
Please describe the tests you used to validate this pull request. Provide any relevant details for test configurations as well as any instructions to reproduce these results.
Verification
Insert x into the following checkboxes to confirm (eg. [x]):