Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow avm executing the balance transfer #863

Merged
merged 1 commit into from
Apr 2, 2019

Conversation

AionJayT
Copy link
Collaborator

@AionJayT AionJayT commented Mar 29, 2019

Notice

It is not allowed to submit your PR to the master branch directly, please submit your PR to the master-pre-merge branch.

Description

relate with #862

Fixes Issue # .

Type of change

Insert x into the following checkboxes to confirm (eg. [x]):

  • Bug fix.
  • New feature.
  • Enhancement.
  • Unit test.
  • Breaking change (a fix or feature that causes existing functionality to not work as expected).
  • Requires documentation update.

Testing

Please describe the tests you used to validate this pull request. Provide any relevant details for test configurations as well as any instructions to reproduce these results.

  • Added test cases to align the fvm&avm behavior.
  • fully sync with mastery

Verification

Insert x into the following checkboxes to confirm (eg. [x]):

  • I have self-reviewed my own code and conformed to the style guidelines of this project.
  • New and existing tests pass locally with my changes.
  • I have added tests for my fix or feature.
  • I have made appropriate changes to the corresponding documentation.
  • My code generates no new warnings.
  • Any dependent changes have been made.

@AionJayT AionJayT added this to the 0.4.0 milestone Mar 29, 2019
@AionJayT AionJayT changed the title 1.) updating avm libs and fixing test case Allow avm executing the balance transfer Mar 29, 2019
/**
* Rules for validating transactions based on allowed types.
*
* @author Alexandra Roatis
*/
public class TransactionTypeRule {

// allowing only balance transfers on AVM when this flag is equal to false.
private static boolean DEPLOY_AVM_CONTRACT_ALLOWED = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this will have to be set to true on the AVM test network branches.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the settings for the avmtestnet.

@AionJayT AionJayT force-pushed the allow-balance-transfer-in-avm branch from 9bec7de to b827419 Compare March 29, 2019 21:12
@AionJayT
Copy link
Collaborator Author

AionJayT commented Apr 2, 2019

waiting AVM bug fix get merged and update this PR then merge into mpm

@AionJayT AionJayT modified the milestones: 0.4.0, 0.3.4 Apr 2, 2019
@AionJayT AionJayT force-pushed the allow-balance-transfer-in-avm branch from dbba111 to c4ca25e Compare April 2, 2019 15:37
        2.) Allow the balance transfer executing inside the avm
@AionJayT AionJayT force-pushed the allow-balance-transfer-in-avm branch from c4ca25e to f124788 Compare April 2, 2019 16:26
@AionJayT AionJayT merged commit 7586210 into master-pre-merge Apr 2, 2019
@AionJayT AionJayT deleted the allow-balance-transfer-in-avm branch April 2, 2019 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants