Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce log level for some tests #877

Merged
merged 1 commit into from
Apr 12, 2019
Merged

Conversation

aion-kelvin
Copy link
Contributor

Notice

It is not allowed to submit your PR to the master branch directly, please submit your PR to the master-pre-merge branch.

Description

Please include a brief summary of the change that this pull request proposes. Include any relevant motivation and context. List any dependencies required for this change.

  • This is an attempt to avoid Jenkins running out of heap memory when trying to parse the XML output of our unit tests

  • I noticed that some of the XML files are really large. This PR changes the logging levels of two of the large files (size in kB):

      1199180 ./modAionImpl/test/TEST-org.aion.zero.impl.BlockchainImplementationTest.xml
      24100   ./modAionImpl/test/TEST-org.aion.zero.impl.vm.OldTxExecutorTest.xml
    
  • Example of failure: https://ci.aion.network:8443/job/aionnetwork/job/jenkins-no-gradle-daemon/5/console

  • After this change, both files are <80 kB

Fixes Issue # .

Type of change

Insert x into the following checkboxes to confirm (eg. [x]):

  • Bug fix.
  • New feature.
  • Enhancement.
  • Unit test.
  • Breaking change (a fix or feature that causes existing functionality to not work as expected).
  • Requires documentation update.

Testing

Please describe the tests you used to validate this pull request. Provide any relevant details for test configurations as well as any instructions to reproduce these results.

Verification

Insert x into the following checkboxes to confirm (eg. [x]):

  • I have self-reviewed my own code and conformed to the style guidelines of this project.
  • New and existing tests pass locally with my changes.
  • I have added tests for my fix or feature.
  • I have made appropriate changes to the corresponding documentation.
  • My code generates no new warnings.
  • Any dependent changes have been made.

@aion-kelvin aion-kelvin added the build script Build script change only label Apr 12, 2019
@aion-kelvin aion-kelvin self-assigned this Apr 12, 2019
@AlexandraRoatis AlexandraRoatis merged commit 5e48d7d into master-pre-merge Apr 12, 2019
@AionJayT AionJayT deleted the quieter-tests branch April 17, 2019 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build script Build script change only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants