Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using 2 transaction types #883

Merged
merged 6 commits into from
Apr 26, 2019
Merged

Switch to using 2 transaction types #883

merged 6 commits into from
Apr 26, 2019

Conversation

AlexandraRoatis
Copy link
Contributor

@AlexandraRoatis AlexandraRoatis commented Apr 18, 2019

Description

  • DEFAULT=0x1 and AVM_CREATE_CODE=0x2
  • InternalVmType enum for managing the VM type stored in the database
  • bug fix for consensus bug
  • a consensus test for block 1023849

Type of change

Insert x into the following checkboxes to confirm (eg. [x]):

  • Bug fix.
  • New feature.
  • Enhancement.
  • Unit test.
  • Breaking change (a fix or feature that causes existing functionality to not work as expected).
  • Requires documentation update.

Testing

Please describe the tests you used to validate this pull request. Provide any relevant details for test configurations as well as any instructions to reproduce these results.

Verification

Insert x into the following checkboxes to confirm (eg. [x]):

  • I have self-reviewed my own code and conformed to the style guidelines of this project.
  • New and existing tests pass locally with my changes.
  • I have added tests for my fix or feature.
  • I have made appropriate changes to the corresponding documentation.
  • My code generates no new warnings.
  • Any dependent changes have been made.

@AlexandraRoatis AlexandraRoatis added the wip Indicates that a PR or issue is Work In Progress, issuer should be notified before any actions label Apr 18, 2019
@AlexandraRoatis AlexandraRoatis self-assigned this Apr 18, 2019
@AionJayT AionJayT mentioned this pull request Apr 25, 2019
12 tasks
@AlexandraRoatis AlexandraRoatis added enhancement New feature or request unit tests and removed wip Indicates that a PR or issue is Work In Progress, issuer should be notified before any actions labels Apr 26, 2019
@AlexandraRoatis AlexandraRoatis added this to the 0.4.0 milestone Apr 26, 2019
@AlexandraRoatis AlexandraRoatis added the bug Something isn't working label Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants