Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed failure deploy contract with an existed account #889

Merged
merged 1 commit into from
May 1, 2019

Conversation

AionJayT
Copy link
Collaborator

Notice

It is not allowed to submit your PR to the master branch directly, please submit your PR to the master-pre-merge branch.

Description

Please include a brief summary of the change that this pull request proposes. Include any relevant motivation and context. List any dependencies required for this change.

  • The current kernel can't deploy a new contract to an existing account (this account might be funded by another account). Therefore, the fix allows the contract deployer deploy a new contract to an existing account without code in the database, which means the destination account only has some balance.

Fixes Issue # .

Type of change

Insert x into the following checkboxes to confirm (eg. [x]):

  • Bug fix.
  • New feature.
  • Enhancement.
  • Unit test.
  • Breaking change (a fix or feature that causes existing functionality to not work as expected).
  • Requires documentation update.

Testing

Please describe the tests you used to validate this pull request. Provide any relevant details for test configurations as well as any instructions to reproduce these results.

  • added test cases in the contractIntegTest.

Verification

Insert x into the following checkboxes to confirm (eg. [x]):

  • I have self-reviewed my own code and conformed to the style guidelines of this project.
  • New and existing tests pass locally with my changes.
  • I have added tests for my fix or feature.
  • I have made appropriate changes to the corresponding documentation.
  • My code generates no new warnings.
  • Any dependent changes have been made.

@AionJayT AionJayT added the bug Something isn't working label Apr 29, 2019
@AionJayT AionJayT added this to the 0.4.0 milestone Apr 29, 2019
@AionJayT AionJayT self-assigned this Apr 29, 2019
@AionJayT AionJayT force-pushed the AKI-83 branch 3 times, most recently from d8d5e9e to 5efa293 Compare April 30, 2019 22:24
@AionJayT AionJayT merged commit 255033b into master-pre-merge May 1, 2019
@AionJayT AionJayT deleted the AKI-83 branch May 2, 2019 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant