Remove unused functionality from the InternalTransactionInterface #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajasek
force-pushed
the
aayush-internalTx
branch
from
04624d3 to
efb79fd
Compare
AionJayT
reviewed
May 1, 2019
| @@ -287,18 +287,6 @@ public void testRecursiveCall() throws InterruptedException, VMException { | |||
| AionTxExecSummary summary = exec.execute().get(0); | |||
|
|
|||
| assertEquals(2, summary.getInternalTransactions().size()); | |||
|
|
|||
There was a problem hiding this comment.
reason for removing the test section?
There was a problem hiding this comment.
The functions tested in this section are being deleted
arajasek
force-pushed
the
aayush-internalTx
branch
4 times, most recently
from
0c2138b to
542b133
Compare
arajasek
force-pushed
the
aayush-internalTx
branch
from
542b133 to
7b86380
Compare
AionJayT
approved these changes
May 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice
It is not allowed to submit your PR to the master branch directly, please submit your PR to the master-pre-merge branch.
Description
These methods were forcing us to leave several methods unimplemented in the AVM. Since they are not used anywhere, and aren't consensus-critical, we can just take them out.
Type of change
Insert x into the following checkboxes to confirm (eg. [x]):
Testing
Passes the CI
Verification
Insert x into the following checkboxes to confirm (eg. [x]):