Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re #560: --redo-import now rewrites the index and prunes side chains #929

Merged
merged 1 commit into from
Jul 15, 2019
Merged

Re #560: --redo-import now rewrites the index and prunes side chains #929

merged 1 commit into from
Jul 15, 2019

Conversation

AlexandraRoatis
Copy link
Contributor

Description

  • Corrected the bug where multiple index entries were introduced for the same block during the rebuild.
  • Also rewriting the index database and removing side chain blocks from the block database.

Type of change

Insert x into the following checkboxes to confirm (eg. [x]):

  • Bug fix.
  • New feature.
  • Enhancement.
  • Unit test.
  • Breaking change (a fix or feature that causes existing functionality to not work as expected).
  • Requires documentation update.

Testing

  • Ran the command on a correct database with side chains and one with incorrect index entries. Ensured that both databases are correct after the --redo-import execution with start from the genesis block and start from a block > 0.

@AlexandraRoatis AlexandraRoatis added bug Something isn't working enhancement New feature or request labels Jul 11, 2019
@AlexandraRoatis AlexandraRoatis requested a review from AionJayT July 11, 2019 17:25
@AlexandraRoatis AlexandraRoatis self-assigned this Jul 11, 2019
@AlexandraRoatis AlexandraRoatis added this to the 0.4.2 milestone Jul 11, 2019
@AlexandraRoatis AlexandraRoatis merged commit 736251f into master-pre-merge Jul 15, 2019
@AlexandraRoatis AlexandraRoatis deleted the issue-560 branch July 15, 2019 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AionJayT AionJayT AionJayT approved these changes

Assignees

@AlexandraRoatis AlexandraRoatis

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
0.4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexandraRoatis @AionJayT