Clean up #953
Merged
Clean up #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed AbstractTxInfo class and unused parentBlockHash functionality from AionTxInfo. - Moved the TransactionStore to modAionImpl since it was only used in this package. It can now see the AionTxInfo without the need for an abstract implementation. - Refactored blockchain interfaces to add the getTransactionInfo method only in the adequate package, moving its declaration from modMcf to modAionImpl.
…ate to a separate class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some refactoring and clean up to simplify the use of
AionTxInfoandAionTxReceiptclasses.Type of change
Insert x into the following checkboxes to confirm (eg. [x]):