FVM external state return FvmDataword instead of long in the block difficulty #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
##Description
Revised the block difficulty return type in the ExternalStateForFVM from long to FvmDataword.
The block difficulty allows max 16 bytes of data been stored in the block header. We should not use long type as the getter/setter to interact with the fastvm.
Relate with the commit in the aion_fastvm repo: aionnetwork/aion_fastvm@166bdb2
Type of change
Insert x into the following checkboxes to confirm (eg. [x]):