AKI-326: Remove external module dependencies from p2p #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandraRoatis
force-pushed
the
AKI-326
branch
2 times, most recently
from
0dd06ee to
5b157bc
Compare
AlexandraRoatis
force-pushed
the
AKI-326
branch
2 times, most recently
from
85c8133 to
2a53147
Compare
- removed multiple getters for the chain id; - avoid indirect access by the AionHub; - exposed only required functionality in the IP2pMgr interface;
AlexandraRoatis
force-pushed
the
AKI-326
branch
from
2a53147 to
7716197
Compare
|
I added 3 more commits, one to detach modApiServer from p2p and the other two to clean up some of the exposed p2p functionality. |
AlexandraRoatis
force-pushed
the
AKI-326
branch
2 times, most recently
from
b18c2e3 to
abf542a
Compare
AlexandraRoatis
force-pushed
the
AKI-326
branch
from
abf542a to
f05a1ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Loggerobject is now passed as input to constructors and methods.Nodeclass implements its own hex string conversion with unit tests to ensure correctness.Fixes Issue AKI-326.
Type of change
Insert x into the following checkboxes to confirm (eg. [x]):