Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analysis logs #970

Merged
merged 2 commits into from
Aug 27, 2019
Merged

Analysis logs #970

merged 2 commits into from
Aug 27, 2019

Conversation

AlexandraRoatis
Copy link
Contributor

@AlexandraRoatis AlexandraRoatis commented Aug 27, 2019

Description

Timing runtime critical operations for survey on sync time distribution:

  • introduced a new logging level SURVEY for runtime stats;
  • TaskImportBlocks logs times according to stages in the import algorithm;
  • ResStatusHandler, ResBlocksHeadersHandler, ResBlocksBodiesHandler and BroadcastNewBlockHandler log times for decoding and validating blocks.

The CLI edit option can now add entries that were not in the initial config.

Type of change

Insert x into the following checkboxes to confirm (eg. [x]):

  • Bug fix.
  • New feature.
  • Enhancement.
  • Unit test.
  • Breaking change (a fix or feature that causes existing functionality to not work as expected).
  • Requires documentation update.

@AlexandraRoatis AlexandraRoatis added the enhancement New feature or request label Aug 27, 2019
@AlexandraRoatis AlexandraRoatis added this to the 0.4.2 milestone Aug 27, 2019
@AlexandraRoatis AlexandraRoatis self-assigned this Aug 27, 2019
 - introduced a new logging level SURVEY for runtime stats;
 - TaskImportBlocks logs times according to stages in the import algorithm;
 - ResStatusHandler, ResBlocksHeadersHandler, ResBlocksBodiesHandler and BroadcastNewBlockHandler
 log times for decoding and validating blocks.
Copy link
Collaborator

@AionJayT AionJayT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexandraRoatis AlexandraRoatis merged commit ccf90bc into master Aug 27, 2019
@AlexandraRoatis AlexandraRoatis deleted the analysis-logs branch August 27, 2019 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants