-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added getBlockdDetails method [AKI-351] #974
Conversation
7f9a208
to
9ec6b0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, looks pretty good overall, but have a few questions/suggestions. Also, would it be possible to add some tests around this?
9ec6b0d
to
d43643b
Compare
Looks good. One last thing -- can you also check that the following all give the same result? Looking at the code, I think they do, but just want to see it work in real life ... if these are all equivalent, then let's merge it:
|
The change was re-tested using the following requests and re-running the tests in the dashboard ETL code.
|
d43643b
to
238c69f
Compare
238c69f
to
1290b5d
Compare
Description
This change adds a new ops_getBlockDetails method which returns a blockdetails similar to the blockdetails found in the Java API.
Fixes Issue # AKI-351
Type of change
Testing