AKI-358: synchronize on account unlocking & locking #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandraRoatis
approved these changes
Sep 12, 2019
- This is to fix an OutOfMemory issue that occurs when multiple rpc threads are attempting to unlock (or lock) accounts simultaneously. This is a very memory-intensive call, requiring 200-230MB of space for each call. The synchronization here prevents multiple threads from allocating this space concurrently and therefore allows for it to be gc'ed, keeping the memory usage low in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
are attempting to unlock (or lock) accounts simultaneously. This is a very
memory-intensive call, requiring 200-230MB of space for each call. The
synchronization here prevents multiple threads from allocating this space
concurrently and therefore allows for it to be gc'ed, keeping the memory
usage low in this case.