removed bad casts in RPC methods[AKI-409] #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AionJayT
reviewed
Sep 26, 2019
AionJayT
reviewed
Sep 26, 2019
dev-dennis-guye
force-pushed
the
AKI-409
branch
3 times, most recently
from
f628629 to
3ed054e
Compare
-returned last pow block in stratum_getMiningInfo -ignored pos case in stratum_getHeaderByBlockNumber
dev-dennis-guye
force-pushed
the
AKI-409
branch
from
3ed054e to
3285971
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes casts from the generic Block type to the POW AionBlock type which caused failures in several RPC methods
Fixes Issue # AKI-409
Type of change
Insert x into the following checkboxes to confirm (eg. [x]):
Testing
Ran from the command line
curl localhost:8545 -H 'Content-Type: application/json' -s -d '{"json-Mc":"2.0","method":"eth_getBlockByNumber","params": {"block":82707}}' | jq