Nick multiversion cleanup #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The modAvmProvider module was a temporary module used as a sandboxed version of modVM during the multi-version avm support development. Now that that's done, the two modules can become one.
- This only made sense in the old world when modAvmProvider existed. Now the configurations class has direct access to the TxNrgRule class and these rules never change.
- Tests now delegate to a helper method to handle the avm configuration boilerplate.
- This was requested because this builder is building a class named AvmExternalState.
aionick
force-pushed
the
nick-multiversion-cleanup
branch
from
2438880 to
e393921
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some final changes as part of the mult-version support.
The most notable change here: squashing
modAvmProviderintomodVM.