Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AIP-134): Make update_mask field must be optional #1327

Merged
merged 7 commits into from
May 16, 2024
Merged

feat(AIP-134): Make update_mask field must be optional #1327

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b0fa299
update field mask guidance for dealing with output only fields
itsStrobe Oct 18, 2023
b65cd9d
update aip-134 guidance to state update_mask field must be optional
itsStrobe Mar 14, 2024
649dde7
Merge remote-tracking branch 'origin/master' into update-aip-134
itsStrobe Mar 14, 2024
2f26e7b
add changelog
itsStrobe Mar 14, 2024
fbec9fe
Merge branch 'master' into update-aip-134
itsStrobe Apr 12, 2024
9f43135
Merge branch 'master' into update-aip-134
itsStrobe May 15, 2024
1c83047
Merge branch 'master' into update-aip-134
noahdietz May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions aip/general/0134.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,9 @@ message UpdateBookRequest {
called `update_mask`.
- The fields used in the field mask correspond to the resource being updated
(not the request message).
- The field **may** be required or optional. If it is required, it **must**
include the corresponding annotation. If optional, the service **must**
treat an omitted field mask as an implied field mask equivalent to all
fields that are populated (have a non-empty value).
- The field **must** be optional, and the service **must** treat an omitted
field mask as an implied field mask equivalent to all fields that are
populated (have a non-empty value).
- Update masks **must** support a special value `*`, meaning full replacement
(the equivalent of `PUT`).
- The request message **must not** contain any other required fields, and
Expand Down Expand Up @@ -298,6 +297,7 @@ does not exist, the service **must** error with `NOT_FOUND` (HTTP 404) unless

## Changelog

- **2024-03-14**: Make `update_mask` optional field_behaviour guidance a **must**.
- **2023-08-26**: Adding consistency requirement.
- **2023-07-17**: Make `update_mask` name guidance a **must**.
- **2022-11-04**: Aggregated error guidance to AIP-193.
Expand Down
Loading