Redirect to browser after build #535
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #535 +/- ##
==========================================
- Coverage 64.79% 64.06% -0.73%
==========================================
Files 10 10
Lines 1156 1166 +10
==========================================
- Hits 749 747 -2
- Misses 327 338 +11
- Partials 80 81 +1 ☔ View full report in Codecov by Sentry. |
| @@ -2,6 +2,7 @@ package runner | |||
|
|
|||
| import ( | |||
| "fmt" | |||
| "github.com/pkg/browser" | |||
There was a problem hiding this comment.
You are advised to change the dependency location according to the following rules:
- Official dependence.
- External dependencies
- Internal dependencies
| @@ -20,6 +20,7 @@ require ( | |||
| github.com/mattn/go-colorable v0.1.13 // indirect | |||
| github.com/mattn/go-isatty v0.0.17 // indirect | |||
| github.com/pelletier/go-toml/v2 v2.0.6 // indirect | |||
| github.com/pkg/browser v0.0.0-20240102092130-5ac0b6a4141c // indirect | |||
There was a problem hiding this comment.
It seems to me that this project package, which has not been maintained for quite some time, may need to be considered for using this package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AppUrlis used to open browser URL when the build is finished.AppUrlOpenDelaywaits when server is ready to accept requests.