#41: Add container element to fix behaviour in responsive mode #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeiP
added a commit
to ZeiP/tracks
that referenced
this pull request
Jun 27, 2019
…applied. Adds a container around each chart allowing to enable responsivity and get a less fuzzy chart.
mattr-
added a commit
to TracksApp/tracks
that referenced
this pull request
Nov 13, 2019
#2259: Use a Chartjs-ror version with airblade/chartjs-ror#57 applied…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #41, the width and height attributes work poorly without a container element around the canvas, this is also mentioned in https://www.chartjs.org/docs/latest/general/responsive.html#important-note. This PR makes chartjs-ror create an container element for the canvas to fix this behaviour.