-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to babel 7 #48
Conversation
380bbb1
to
f4164b0
Compare
Removed Node v4,5 & 7 from Travis testing as they have reached End-of-life. https://github.com/nodejs/Release (Technically 9 has as well) This fixes the tests as Babel doesn't seem to support 4,5,7 anymore. Not sure why the tests are failing... They were just passing locally and all were passing on the first commit except 4 & 5. |
This might be due to ES6-style module-loading not fully working with babel-node. Maybe try changing |
package.json
Outdated
"@babel/core": "^7.0.0", | ||
"@babel/node": "^7.0.0", | ||
"@babel/preset-react": "^7.0.0", | ||
"babel-preset-airbnb": "vikr01/babel-preset-airbnb#feature/babel-7", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can't merge until we're using the actual package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stramel this one's merged! airbnb/babel-preset-airbnb#37 thanks @ljharb
@vikr01 that's just for the repl; it shouldn't be needed here |
debugging diff revert revert preset revert
cae7ace
to
4a075ae
Compare
@ljharb This should be ready to go now.
|
516280d
to
83cae6f
Compare
Fixes #41
Currently dependent on airbnb/babel-preset-airbnb#37 Shoutout to @vikr01 for that PR
/cc @ljharb