Fix transforming via API #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- forbid the option when transforming a file Fixes #52.
|
@danoc, can you test out this solution? |
| const { ignorePattern, caseSensitive } = state.opts; | ||
| const { file } = state; | ||
| const { ignorePattern, caseSensitive, filename: providedFilename } = state.opts; | ||
| const { file, filename } = state; |
There was a problem hiding this comment.
Looks like filename was originally coming from state.file.opts on ln 47, was this updated somewhere?
There was a problem hiding this comment.
I'm no longer using that value, but it seems like it will be populated by state.filename when transforming a file, and state.opts.filename when the option is provided, so this seemed more straightforward.
sharmilajesupaul
approved these changes
Oct 22, 2018
|
Hi, a few minutes late to the party but when I test this locally I get the following error: Does If I omit |
|
@danoc what config are you using with that first error? |
|
@ljharb Using this config: If I change filename to Could be something wrong on my end. I'm testing this by pulling down the code in this PR, building the |
|
@danoc when providing options to a plugin, you need an extra wrapping array. Try this: const es = babelTransform(buildFile(componentName, path), {
presets: ['@babel/preset-env', '@babel/preset-react'],
plugins: [['inline-react-svg', { filename: 'unknown' }]],
babelrc: false,
}).code; |
|
Ah, nice catch. That was the issue. I really appreciate your help on this! 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.