Register export declaration in scope #77
Conversation
| pre() { | ||
| console.warn = (msg) => { throw new Error(`Got console.warn: ${msg}`); }; | ||
| }, | ||
| }), |
There was a problem hiding this comment.
if some plugin call console.warn - fail the transformation. Inspired by test added to transform-typescript plugin
¯\_(ツ)_/¯
| [transformTs, { isTSX: true }], | ||
| () => ({ | ||
| pre() { | ||
| console.warn = (msg) => { throw new Error(`Got console.warn: ${msg}`); }; |
There was a problem hiding this comment.
| console.warn = (msg) => { throw new Error(`Got console.warn: ${msg}`); }; | |
| console.warn = function warn(msg) { throw new Error(`Got console.warn: ${msg}`); }; |
this seems worth adding to every test?
|
@oleg-rdk do you plan to revisit this PR? The warning is super annoying =) |
|
If not, someone who wants it to land can post a link (not a new PR) to a branch or commit that rebases and accounts for review comments, and I’ll pull it into this PR. |
|
@ljharb I have pulled @oleg-rdk's branch, rebase it on master and tackle your comments: https://github.com/briganti/babel-plugin-inline-react-svg/commits/fix-declaration-warning let me know if you need anything, I too need this PR released 🙂 |
|
@lencioni sorry to drag you in this, but I've noticed you also have contributed to this project. is there anything you can do to make this fix merged? I would really appreciate it. |
|
@briganti I haven't gotten to it yet, is all, but will do so soon. |
|
Would be happy to contribute to this as well! Anything I can do to help this get landed? |
|
👋 I'm happy to help too but it seems @briganti's branch is still as ready as ever. So this is just a friendly reminder about this PR that I'd also like to see merged! 😃 |
… `eslint`, `eslint-config-airbnb`, `eslint-plugin-import`, `eslint-plugin-jsx-a11y`, `eslint-plugin-react`
ljharb
force-pushed
the
fix-declaration-warning
branch
from
8dc7d6b to
66dfa52
Compare
|
This PR is now good to go on its own, but is blocked for the same reason as #116 (comment). |
Fixes airbnb#74. Co-authored-by: Oleg Buiar <[email protected]> Co-authored-by: Michael Vial <[email protected]>
ljharb
force-pushed
the
fix-declaration-warning
branch
from
66dfa52 to
6e130a5
Compare
|
@ljharb sorry to keep bugging you but would it be possible to tag a new version now that a few PRs (including this one) have been merged? |
|
@simleb i just got permissions sorted out yesterday so that i can release; i'll try to do that in the next couple days. |
|
v2.0.2 is released. |
Fixes #74