Skip to content

Commit

Permalink
Adding LONG to list of numeric types, updating TODO
Browse files Browse the repository at this point in the history
mistercrunch committed Mar 28, 2016

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
1 parent 26c7251 commit 09021aa
Showing 2 changed files with 3 additions and 4 deletions.
5 changes: 2 additions & 3 deletions TODO.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
# TODO
List of TODO items for Dashed

range filter formatter
sankey example is missing

## Important
* **Getting proper JS testing:** unit tests on the Python side are pretty
solid, but now we need a test suite for the JS part of the site,
@@ -39,6 +36,8 @@ sankey example is missing


## Easy-ish fix
* Build matrix to include mysql using tox
* Figure out why coverage isn't working
* Kill switch for Druid in docs
* CREATE VIEW button from SQL editor
* Test button for when editing SQL expression
2 changes: 1 addition & 1 deletion dashed/models.py
Original file line number Diff line number Diff line change
@@ -634,7 +634,7 @@ def fetch_metadata(self):
db.session.flush()
if not dbcol:
dbcol = TableColumn(column_name=col.name)
num_types = ('DOUBLE', 'FLOAT', 'INT', 'BIGINT')
num_types = ('DOUBLE', 'FLOAT', 'INT', 'BIGINT', 'LONG')
datatype = str(datatype).upper()
if (
str(datatype).startswith('VARCHAR') or

0 comments on commit 09021aa

Please sign in to comment.