Do not create DotLottieImageProvider instance if there's no image f…

…iles (#2271)
airbnb · Jan 3, 2024 · af18de2 · af18de2
1 parent 9c1e7f1
commit af18de2
Show file tree

Hide file tree

Showing 13 changed files with 5 additions and 4 deletions.
diff --git a/Sources/Private/Model/DotLottie/DotLottieImageProvider.swift b/Sources/Private/Model/DotLottie/DotLottieImageProvider.swift
@@ -22,12 +22,12 @@ class DotLottieImageProvider: AnimationImageProvider {
   ///
   /// - Parameter filepath: The absolute filepath containing the images.
   ///
-  init(filepath: String) {
-    self.filepath = URL(fileURLWithPath: filepath)
-    loadImages()
+  convenience init?(filepath: String) {
+    self.init(filepath: URL(fileURLWithPath: filepath))
   }
 
-  init(filepath: URL) {
+  init?(filepath: URL) {
+    guard filepath.urls.count > 0 else { return nil }
     self.filepath = filepath
     loadImages()
   }

diff --git a/Tests/Samples/Issues/pr_2271.lottie b/Tests/Samples/Issues/pr_2271.lottie
diff --git a/Tests/__Snapshots__/AutomaticEngineTests/testAutomaticEngineDetection.Issues-pr_2271.txt b/Tests/__Snapshots__/AutomaticEngineTests/testAutomaticEngineDetection.Issues-pr_2271.txt
@@ -0,0 +1 @@
+Supports Core Animation engine
diff --git a/...Snapshots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-pr_2271-0.png b/...Snapshots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-pr_2271-0.png
diff --git a/...apshots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-pr_2271-100.png b/...apshots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-pr_2271-100.png
diff --git a/...napshots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-pr_2271-25.png b/...napshots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-pr_2271-25.png
diff --git a/...napshots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-pr_2271-50.png b/...napshots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-pr_2271-50.png
diff --git a/...napshots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-pr_2271-75.png b/...napshots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-pr_2271-75.png
diff --git a/.../__Snapshots__/SnapshotTests/testMainThreadRenderingEngine.Issues-pr_2271-0.png b/.../__Snapshots__/SnapshotTests/testMainThreadRenderingEngine.Issues-pr_2271-0.png
diff --git a/..._Snapshots__/SnapshotTests/testMainThreadRenderingEngine.Issues-pr_2271-100.png b/..._Snapshots__/SnapshotTests/testMainThreadRenderingEngine.Issues-pr_2271-100.png
diff --git a/...__Snapshots__/SnapshotTests/testMainThreadRenderingEngine.Issues-pr_2271-25.png b/...__Snapshots__/SnapshotTests/testMainThreadRenderingEngine.Issues-pr_2271-25.png
diff --git a/...__Snapshots__/SnapshotTests/testMainThreadRenderingEngine.Issues-pr_2271-50.png b/...__Snapshots__/SnapshotTests/testMainThreadRenderingEngine.Issues-pr_2271-50.png
diff --git a/...__Snapshots__/SnapshotTests/testMainThreadRenderingEngine.Issues-pr_2271-75.png b/...__Snapshots__/SnapshotTests/testMainThreadRenderingEngine.Issues-pr_2271-75.png