Fix CoreAnimation playbackState race condition
#1727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calda
approved these changes
Aug 23, 2022
calda
reviewed
Aug 23, 2022
| @@ -331,7 +331,7 @@ extension CoreAnimationLayer: RootAnimationLayer { | |||
| var isAnimationPlaying: Bool? { | |||
| switch playbackState { | |||
| case .playing: | |||
| return animation(forKey: #keyPath(animationProgress)) != nil | |||
| return pendingAnimationConfiguration?.playbackState == .playing || animation(forKey: #keyPath(animationProgress)) != nil | |||
There was a problem hiding this comment.
Why does this pendingAnimationConfiguration?.playbackState == .playing check need to be nested in the playbackState == .playing branch? Could we move it out of the switch and have it be checked first?
What happens if pendingAnimationConfiguration?.playbackState == .playing when playbackState == .paused or nil? Is there a reason we only have to do this check when another animation is already playing?
There was a problem hiding this comment.
That's a good point, I guess I was too focused on that this is the line that changed and therefore I wanted to put it there. I'll push a different proposal and you can react to that :-D
calda
pushed a commit
that referenced
this pull request
Nov 28, 2022
…mation set by `AnimationView` (#1727)
calda
pushed a commit
that referenced
this pull request
Dec 1, 2022
…mation set by `AnimationView` (#1727)
MoroziOS
pushed a commit
to MoroziOS/tmg-lottie-ios
that referenced
this pull request
May 22, 2024
…mation set by `AnimationView` (airbnb#1727)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1682 introduced a bug where infinitely looping animations would sometimes report as not playing. I think this is because the property is read while a new animation is scheduled but haven't yet been applied through the
displaylifecycle method. This PR changes theplaybackStateto take the pending animation configuration into consideration which fixes the bug on our end, but happy to see if you have a better approach at fixing this.