Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI jobs to run on Apple Silicon macOS 14 runner #2306

Merged
merged 4 commits into from
Feb 1, 2024

Conversation

calda
Copy link
Member

@calda calda commented Jan 31, 2024

GitHub released a new macOS 14 runner that uses Apple Silicon: https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/

This PR adopts the new macOS 14 runner. Since we now run our CI jobs on Apple Silicon, we no longer need the workaround for using the visionOS SDK on Intel.

The Apple Silicon runner is also WAY FASTER than the previous Intel runner. Now our tests complete in about 7 minutes, compared to 22 minutes on the Intel runner.

Copy link

emerge-tools bot commented Jan 31, 2024

1 build decreased size

Name Version Download Change Install Change
SizeTest
com.airbnb.lottie.sizetest.iOS
1.0 (1) 753.0 kB ⬇️ 24.4 kB (-3.14%) 2.3 MB ⬇️ 46.5 kB (-2.03%)

SizeTest 1.0 (1)
com.airbnb.lottie.sizetest.iOS

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬇️ 46.5 kB (-2.03%)
Total download size change: ⬇️ 24.4 kB (-3.14%)

Largest size changes

Item Install Size Change
Lottie.UnsafeMutableBufferPointer._stableSortImpl(by) ⬇️ -6.1 kB
Lottie.CALayer.animationGroup(for,animationSegments,value,context... ⬇️ -4.5 kB
Lottie.CALayer.keyframeAnimation(for,keyframes,value,customKeyTim... ⬆️ 3.9 kB
Lottie.Dictionary.value(for,file,line) ⬆️ 2.9 kB
Lottie.RawRepresentable.hashValue ⬆️ 2.7 kB

Image of diff


🛸 Powered by Emerge Tools

@calda calda marked this pull request as ready for review January 31, 2024 23:12
@@ -1,5 +1,5 @@
source 'https://rubygems.org' do
gem 'cocoapods', '~> 1.11.0'
gem 'cocoapods', '~> 1.15.0'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bundle exec rake lint:podspec was failing on macOS 14 with Cocoapods 1.11.0. Updating to the latest version fixed the issue.

@calda calda merged commit 2aa558f into master Feb 1, 2024
14 checks passed
@calda calda deleted the cal--m1-macos-14 branch February 1, 2024 00:27
MoroziOS pushed a commit to MoroziOS/tmg-lottie-ios that referenced this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants