-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for visionOS #12
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
77b2645
Add support for visionOS
calda 1315ec0
Test CI with build from Xcode 15.2
calda f4da9b1
Update set of Xcode versions
calda 99657f1
Test example app under more Xcode versions
calda 3ceab75
test more things
calda 450ac43
Lower deployment target of Example app to fix CI error
calda 8785f12
Fix issue
calda 7d2c799
Test with explicit visionOS download
calda 59c05e3
Enable visionOS support on Intel
calda ad486dc
Fix issue where Example app build ignored Xcode version options
calda 406ee19
Clean up test code. visionOS build will fail until we release and pul…
calda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
92 changes: 0 additions & 92 deletions
92
Example/Example.xcodeproj/xcshareddata/xcschemes/Example (iOS).xcscheme
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
5 changes: 5 additions & 0 deletions
5
...xcassets/AppIcon.appiconset/Contents.json → ...xcassets/AppIcon.appiconset/Contents.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
// Created by Cal Stephens on 9/12/23. | ||
// Copyright © 2023 Airbnb Inc. All rights reserved. | ||
|
||
import SwiftUI | ||
import Lottie | ||
|
||
struct ContentView: View { | ||
var body: some View { | ||
VStack { | ||
Spacer() | ||
Text("lottie-spm") | ||
Spacer() | ||
|
||
LottieView(animation: .named("LottieLogo1")) | ||
.playing(loopMode: .loop) | ||
} | ||
} | ||
} |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
// Created by Cal Stephens on 9/12/23. | ||
// Copyright © 2023 Airbnb Inc. All rights reserved. | ||
|
||
import SwiftUI | ||
|
||
@main | ||
struct ExampleApp: App { | ||
var body: some Scene { | ||
WindowGroup { | ||
ContentView() | ||
} | ||
} | ||
} |
File renamed without changes.
This file was deleted.
Oops, something went wrong.
13 changes: 0 additions & 13 deletions
13
Example/iOS/Assets.xcassets/AppIcon.appiconset/Contents.json
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleted the separate iOS (UIKit) and macOS (AppKit) example apps in favor of a single cross-platform SwiftUI example app.
When we get ready to merge this we'll want to add CI jobs that test all supported platforms on both Xcode 14 and Xcode 15.