This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
John bodley cherry picks #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syntax checking doesn't work if jinja templates haven't been prerendered. Also remove unreachable return statement. Fixes apache#4288. (cherry picked from commit 4ec8258)
(cherry picked from commit d49a0e7)
|
No yarn.lock? |
michellethomas
approved these changes
Mar 30, 2018
michellethomas
pushed a commit
that referenced
this pull request
Dec 1, 2021
…() (#33) * Feat: Use the recently added ExtensibleFunction to make an instance of CategoricalColorScale be a function * BREAKING CHANGE: Remove categoricalColorScale.toFunction(). * BREAKING CHANGE: The color scale no longer convert input to lowercase before finding color. * Fix: Also transform input value before setting color.
michellethomas
pushed a commit
that referenced
this pull request
Dec 1, 2021
michellethomas
pushed a commit
that referenced
this pull request
Dec 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picking apache#4669 and apache#4686 to remedy the Jinja issue.
to: @graceguo-supercat @michellethomas