Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

[WIP] Cherry-pick(s): <description> #82

Closed
wants to merge 1 commit into from

Conversation

kristw
Copy link

@kristw kristw commented Aug 14, 2018

SHA | Time | Log | Author

Cherry-pick the following commit(s):

--- | --- | --- | ---

536478e | Mon Aug 13 16:19:19 2018 -0700 | [feature] Allow min/max value for the sparkline in time series table (apache#5603) (apache/master) | [Krist Wongsuphasawat]

…pache#5603)

* Allow min/max value for the sparkline in time series table

* show bound lines

* User can choose to show y-axis bounds

* show label for the bounds

* compute necessary padding for the bound label

* extract sparkline code to another component

* can show y-axis in sparkline without setting bounds

* reorder option rows

(cherry picked from commit 536478e)
@kristw
Copy link
Author

kristw commented Aug 14, 2018

failed

@kristw kristw closed this Aug 14, 2018
@codecov-io
Copy link

Codecov Report

Merging #82 into airbnb-master will decrease coverage by 0.14%.
The diff coverage is 8.45%.

Impacted file tree graph

@@                Coverage Diff                @@
##           airbnb-master      #82      +/-   ##
=================================================
- Coverage          63.38%   63.23%   -0.15%     
=================================================
  Files                350      351       +1     
  Lines              21978    22037      +59     
  Branches            2450     2463      +13     
=================================================
+ Hits               13930    13935       +5     
- Misses              8036     8090      +54     
  Partials              12       12
Impacted Files Coverage Δ
superset/assets/src/visualizations/time_table.jsx 0% <0%> (ø) ⬆️
...perset/assets/src/visualizations/SparklineCell.jsx 0% <0%> (ø)
superset/assets/src/modules/visUtils.js 58.33% <100%> (ø) ⬆️
...re/components/controls/TimeSeriesColumnControl.jsx 88.46% <71.42%> (-2.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42bdef3...512f41a. Read the comment docs.

@kristw kristw deleted the test-cherry-pick2 branch August 15, 2018 00:12
michellethomas pushed a commit that referenced this pull request Dec 1, 2021
michellethomas pushed a commit that referenced this pull request Dec 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants