This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Cherry-pick(s): allow min/max value , show y-axis for sparklines in time series table #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pache#5603) * Allow min/max value for the sparkline in time series table * show bound lines * User can choose to show y-axis bounds * show label for the bounds * compute necessary padding for the bound label * extract sparkline code to another component * can show y-axis in sparkline without setting bounds * reorder option rows (cherry picked from commit 536478e)
kristw
requested review from
graceguo-supercat,
john-bodley,
michellethomas and
williaster
kristw
changed the title
|
@kristw thanks for putting together the table but in the future it's probably not necessary as GitHub lists all the commit which have been cherry-picked. |
john-bodley
approved these changes
Aug 14, 2018
|
FWIW I dig the table! :) I take it you're writing a script for this?! 💯 If so, great idea / we should all use that or automate it, this takes way too much time! |
|
@john-bodley @williaster Yes, I wrote a shell script for this (create PR from command line and pipe git log into commit message). :) Revising it a bit more and will share with the team. |
michellethomas
pushed a commit
that referenced
this pull request
Dec 1, 2021
michellethomas
pushed a commit
that referenced
this pull request
Dec 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick the following commit(s):
@graceguo-supercat @michellethomas @john-bodley @williaster