Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Rollback cherrypick #5140 #89

Conversation

graceguo-supercat
Copy link
Collaborator

@graceguo-supercat graceguo-supercat commented Aug 15, 2018

apache#5140 has other dependencies that are not available in airbnb-master. have to rollback for now.

@michellethomas @john-bodley

@codecov-io
Copy link

codecov-io commented Aug 15, 2018

Codecov Report

Merging #89 into airbnb-master will increase coverage by <.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@                Coverage Diff                @@
##           airbnb-master      #89      +/-   ##
=================================================
+ Coverage           63.2%   63.21%   +<.01%     
=================================================
  Files                351      351              
  Lines              22043    22039       -4     
  Branches            2465     2465              
=================================================
- Hits               13933    13931       -2     
+ Misses              8098     8096       -2     
  Partials              12       12
Impacted Files Coverage Δ
superset/assets/src/utils/common.js 60% <ø> (-0.53%) ⬇️
superset/viz.py 80.79% <0%> (+0.08%) ⬆️
superset/assets/src/modules/colors.js 77.08% <100%> (-0.47%) ⬇️
superset/assets/src/visualizations/nvd3_vis.js 9.41% <100%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3f33ce...d0a721d. Read the comment docs.

@graceguo-supercat graceguo-supercat merged commit 72f5792 into airbnb:airbnb-master Aug 15, 2018
@graceguo-supercat graceguo-supercat deleted the gg-RollbackCherryPick5140 branch August 15, 2018 00:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants