This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Cherry-picks: Several updates to the chart components #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor Chord vis * Add PropTypes * change module.exports to export default (cherry picked from commit 683edc3)
(cherry picked from commit fdb8001)
I noticed that `secondary_metric` was required in the chart that users it, namely sunburst, parallel coordinates, and world_map. I set the control as allowing null, and found related bugs in the process: * parallel coordinates did not have support for the new MetricControl * added color scheme support for parallel coordinates * added option to set row_limit on these viz types * sunburst to support numeric columns (number would show as blank) (cherry picked from commit 71e0c07)
* Refactor and add props to Force Directed Graph * update label and enable renderTrigger (cherry picked from commit 3929f0f)
* create reactize function * update function signature * adjust word cloud controls * Fix broken word cloud logic * Repair and refactor word cloud * remove file * Add PropTypes * change module.exports to export default * change order * update proptypes (cherry picked from commit 0a40149)
kristw
changed the title
michellethomas
approved these changes
Aug 22, 2018
Codecov Report
@@ Coverage Diff @@
## airbnb-master #96 +/- ##
=================================================
- Coverage 63.25% 63.19% -0.07%
=================================================
Files 351 351
Lines 22037 22055 +18
Branches 2470 2473 +3
=================================================
- Hits 13939 13937 -2
- Misses 8086 8106 +20
Partials 12 12
Continue to review full report at Codecov.
|
michellethomas
pushed a commit
that referenced
this pull request
Dec 1, 2021
michellethomas
pushed a commit
that referenced
this pull request
Dec 1, 2021
* fix: broken build due to vega type * fix: remove unused * fix: type * fix: margin
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick the following commit(s):
I have verified this cherry-picked version on development box and the affected vis are working as expected.
@john-bodley @conglei @graceguo-supercat @kristw @michellethomas @timifasubaa @williaster