Merge pull request #525 from airbrake/1045-poor-error-msg

notice_notifier: fix confusing error message

CHANGELOG.md

@@ -3,6 +3,10 @@ Airbrake Ruby Changelog
 
 ### master
 
+* `NoticeNotifier` fixed confusing error message when trying to build a notice
+  when Airbrake was closed
+  ([#525](https://github.com/airbrake/airbrake-ruby/pull/525))
+
 ### [v4.10.1][v4.10.1] (December 12, 2019)
 
 * Fixed bug in `PerformanceNotifier` where resource's `start_time` and

lib/airbrake-ruby/notice_notifier.rb

@@ -55,7 +55,8 @@ def delete_filter(filter_class)
     def build_notice(exception, params = {})
       if @async_sender.closed?
         raise Airbrake::Error,
-              "attempted to build #{exception} with closed Airbrake instance"
+              "Airbrake is closed; can't build exception: " \
+              "#{exception.class}: #{exception}"
       end
 
       if exception.is_a?(Airbrake::Notice)

spec/notice_notifier_spec.rb

@@ -328,9 +328,9 @@
       end
 
       it "raises error" do
-        expect { subject.build_notice(Exception.new) }.to raise_error(
+        expect { subject.build_notice(Exception.new('oops')) }.to raise_error(
           Airbrake::Error,
-          'attempted to build Exception with closed Airbrake instance',
+          "Airbrake is closed; can't build exception: Exception: oops",
         )
       end
     end