Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration setting for unhandled exceptions #58

Closed
ktimothy opened this issue Mar 10, 2016 · 4 comments
Closed

Configuration setting for unhandled exceptions #58

ktimothy opened this issue Mar 10, 2016 · 4 comments
Labels

Comments

@ktimothy
Copy link

Hey!

Currently airbrake-ruby notifies about unhandled errors, if they cause process exit, and there is no way to prevent airbrake from doing that. What if we add a config property, that will allow to turn off notifying on such exceptions?

@kyrylo
Copy link
Contributor

kyrylo commented Mar 10, 2016

Hey! It's hard to tell because at the moment it's not clear why it would be useful. What's your use case?

@ktimothy
Copy link
Author

Well, I just think that this behavior is not obvious. I really thought, that this gem is developed for notifying airbrake with exceptions manually, not automatically.

@kyrylo
Copy link
Contributor

kyrylo commented Mar 11, 2016

I see your point and I think I agree with this. I'll transfer this behaviour to the airbrake gem instead as it makes more sense there.

Luckily, if you don't use the airbrake gem and only need this one, it's very easy to bring this behaviour back (literally 3 lines of code).

@kyrylo kyrylo mentioned this issue Mar 11, 2016
@ktimothy
Copy link
Author

Nice!

kyrylo added a commit that referenced this issue Mar 11, 2016
Fixes #58 (Configuration setting for unhandled exceptions)

Although we delete this, it is still useful. Therefore, this
functionality is going to be moved to the Airbrake gem instead.
kyrylo added a commit that referenced this issue Mar 11, 2016
Fixes #58 (Configuration setting for unhandled exceptions)

Although we delete this, it is still useful. Therefore, this
functionality is going to be moved to the Airbrake gem instead.
kyrylo added a commit that referenced this issue Mar 11, 2016
Fixes #58 (Configuration setting for unhandled exceptions)

Although we delete this, it is still useful. Therefore, this
functionality is going to be moved to the Airbrake gem instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants