Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for :start_time & :end_time params for Airbrake::PerformanceNotifier #601

Closed
kyrylo opened this issue Aug 11, 2020 · 0 comments · Fixed by #609
Closed

Drop support for :start_time & :end_time params for Airbrake::PerformanceNotifier #601

kyrylo opened this issue Aug 11, 2020 · 0 comments · Fixed by #609
Assignees
@kyrylo

Comments

@kyrylo
Copy link
Contributor

kyrylo commented Aug 11, 2020 •
edited
Loading

As of v4.11.0 (in c1425c5) we deprecated this API:

Airbrake.notify_request(
  ...,
  start_time: start_time,
  end_time: Time.now,
)

We are preparing a new major release and it's high time to delete it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kyrylo kyrylo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

performance_notifier: drop support for :{start,end}_time params airbrake/airbrake-ruby
1 participant
@kyrylo